Skip to content

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Nov 2, 2025

Description

Added an "all" option to indicate typos that both keeps the replace functionality, and makes the below functionality show the correct instead of the incorrect letters. We just check whether the mode is all before deciding whether to pass input to createHintsHtml or to pass currentWord. All functionality of replace and below is kept by just adding or operators to check whether indicateTypos is all OR replace/below.

I'm not so sure whether we need to change the if statement at the start of updateHintsPosition to:

if (
    ActivePage.get() !== "test" ||
    TestState.resultVisible ||
    (Config.indicateTypos !== "below" && Config.indicateTypos !== "all")
  )

It works fine for me without it, but I would still like to get feedback on this.

Implementing #7024

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff packages Changes in local packages labels Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants