-
-
Notifications
You must be signed in to change notification settings - Fork 3k
refactor: input rewrite v3 (@miodec) #7119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add bail out to long tests
pass that data into failorfinish rework failorfinish move failorfinish to the end of ontextinput move ui update to the very end move live burst fail check to failorfinish
to avoid excess space at the end
… actual input if visually the same, move tests around
2 tasks
Miodec
added a commit
that referenced
this pull request
Dec 4, 2025
Together with #7119, input handling is 3x faster. Achieved by: - deferring all UI updates to when the browser is ready and debouncing ui calls. - using vanilla js where needed - caching dom elements - disabling expensive checks if the timer is slow - switching to a timer that uses RAF instead of setTimeout - moving some code around This should make the site smother on slower devices and fix lag spikes causing weird test data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
User interface or web stuff
packages
Changes in local packages
waiting for review
Pull requests that require a review before continuing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input goes brr