Skip to content

fix(custom-theme): Remove duplicate .customTheme selectors (@Leonabcd123) #7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 2 commits into from
Nov 23, 2025
Merged

fix(custom-theme): Remove duplicate .customTheme selectors (@Leonabcd123) #7120

Miodec merged 2 commits into from
Nov 23, 2025

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Nov 18, 2025 •
edited
Loading

Description

Removed duplicate .customTheme selectors to make:

$(`.pageSettings .tabContent.customTheme #${color}[type='color']`).attr(
  "value"
)

Select the custom theme data inputs successfully.

Closes #7121
Closes #7122

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 18, 2025
@Leonabcd123 Leonabcd123 changed the title fix(custom-theme): Fix share custom theme button generating invalid url (@Leonabcd123) fix(custom-theme): Remove duplicate .customTheme selectors (@Leonabcd123) Nov 18, 2025
@Miodec Miodec merged commit 595ff27 into monkeytypegame:master Nov 23, 2025
28 checks passed
@Leonabcd123 Leonabcd123 deleted the fix-share-custom-theme branch November 23, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fehmer fehmer fehmer approved these changes

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update custom theme fails when "Update custom theme to current colors" is checked Share custom theme button generates an invalid url

4 participants

@Leonabcd123 @fehmer @Miodec @monkeytypegeorge