Skip to content

Conversation

@Miodec
Copy link
Member

@Miodec Miodec commented Nov 23, 2025

  • main linting is now done by oxlint. eslint remains for linting json files in the frontend (until oxlint adds support)
  • move type checking to the lint step (with --type-check)
    this improves performance by removing a duplicated typescript parse task (instead of parsing for linting then again for type checking, it parses once for both)
  • add a lint-fast npm script to get some fast fail behavior. it simply lints with no type information
  • oxc plugins are still in preview, so the custom plugin that checks for __testing usage outside of tests runs outside the main linting job until performance is improved
  • fixes some type issues (and config issues) that were not visible due to a missing type check on some files. now type checking will run on every file that is linted
  • split up oxc config for easier management

waiting oxc-project/tsgolint#494

seeing around 3x improvement in type aware linting

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Nov 23, 2025
@socket-security
Copy link

socket-security bot commented Nov 23, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedetag@​1.8.110010010075100
Addedsupertest@​7.1.49910010088100
Addedtypescript@​5.9.31001009010090
Added@​eslint/​json@​0.14.010010010091100

View full report

@monkeytypegeorge monkeytypegeorge added the docs Related to Markdown files and documentation label Nov 23, 2025
@Miodec Miodec requested a review from fehmer November 23, 2025 23:56
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Nov 23, 2025
@Miodec Miodec marked this pull request as ready for review December 15, 2025 13:40
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 15, 2025
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Dec 15, 2025
@Miodec Miodec added the force-ci Force CI to run on draft PRs label Dec 15, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 15, 2025
@Miodec Miodec requested a review from Copilot December 15, 2025 13:55
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project's main linting infrastructure from ESLint to oxlint for improved performance, achieving approximately 3x faster type-aware linting. ESLint is retained solely for linting JSON files in the frontend until oxlint adds native support.

Key Changes:

  • Migrated to oxlint 1.33.0 with oxlint-tsgolint 0.9.0 for type-aware linting
  • Consolidated type checking into the lint step using --type-check flag to eliminate duplicate TypeScript parsing
  • Removed the standalone @monkeytype/eslint-config package
  • Split oxlint configuration into modular files for better maintainability
  • Added lint-fast script for quick linting without type information
  • Updated all disable comments from eslint-disable to oxlint-disable syntax
  • Fixed previously hidden type issues exposed by comprehensive type checking

Reviewed changes

Copilot reviewed 111 out of 112 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
turbo.json Added lint-fast task configuration
pnpm-lock.yaml Updated dependencies: removed eslint from root/backend/packages, added oxlint 1.33.0 and oxlint-tsgolint, upgraded frontend eslint to 9.39.1
package.json Updated root lint scripts to use lint-fast variants, removed eslint dependency
packages/oxlint-config/* Split configuration into modular files (enabled.jsonc, disabled.jsonc, ts-enabled.jsonc, etc.) and added custom plugin support
packages/eslint-config/* Removed entire package as it's no longer needed
frontend/* Migrated to new eslint.config.js for JSON-only linting, updated disable comments, fixed type issues
backend/* Updated lint scripts, migrated disable comments, fixed type issues in DAL and controllers
.github/workflows/monkey-ci.yml Added lint-fast step before full lint for faster feedback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Dec 15, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 15, 2025
fehmer
fehmer previously approved these changes Dec 15, 2025
@socket-security
Copy link

socket-security bot commented Dec 15, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm safer-buffer is 94.0% likely obfuscated

Confidence: 0.94

Location: Package overview

From: pnpm-lock.yamlnpm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@Miodec Miodec merged commit a067a32 into master Dec 15, 2025
13 checks passed
@Miodec Miodec deleted the tsgolint branch December 15, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Server stuff force-ci Force CI to run on draft PRs frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants