-
-
Notifications
You must be signed in to change notification settings - Fork 3k
refactor: remove jQuery from email-handler (@Leonabcd123) #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove jQuery from email-handler (@Leonabcd123) #7304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the email-handler HTML file to remove the jQuery dependency and replace it with native DOM utility functions from the project's custom dom.ts utility module. The refactoring also includes minor adjustments to other files for consistency.
Key changes:
- Removed jQuery import and replaced with custom DOM utilities (
qs,onDOMReady) - Converted all jQuery selectors and method calls to use the
ElementWithUtilsAPI - Simplified the DOMContentLoaded event listener setup using the
onDOMReadyhelper
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/ts/utils/dom.ts | Added documentation comment for the scrollIntoView method |
| frontend/src/ts/pages/profile-search.ts | Replaced custom dispatch("focus") call with native focus() method |
| frontend/src/email-handler.html | Removed jQuery dependency and replaced all jQuery calls with custom DOM utility methods (qs, setHtml, setText, show, hide, getValue, appendHtml, on, focus, onDOMReady) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.