Skip to content

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Jan 2, 2026

No description provided.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 2, 2026
@Leonabcd123 Leonabcd123 marked this pull request as draft January 2, 2026 16:20
@Leonabcd123 Leonabcd123 marked this pull request as ready for review January 2, 2026 19:29
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the email-handler HTML file to remove the jQuery dependency and replace it with native DOM utility functions from the project's custom dom.ts utility module. The refactoring also includes minor adjustments to other files for consistency.

Key changes:

  • Removed jQuery import and replaced with custom DOM utilities (qs, onDOMReady)
  • Converted all jQuery selectors and method calls to use the ElementWithUtils API
  • Simplified the DOMContentLoaded event listener setup using the onDOMReady helper

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
frontend/src/ts/utils/dom.ts Added documentation comment for the scrollIntoView method
frontend/src/ts/pages/profile-search.ts Replaced custom dispatch("focus") call with native focus() method
frontend/src/email-handler.html Removed jQuery dependency and replaced all jQuery calls with custom DOM utility methods (qs, setHtml, setText, show, hide, getValue, appendHtml, on, focus, onDOMReady)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jan 6, 2026
@Miodec Miodec merged commit 8c9ca7d into monkeytypegame:master Jan 6, 2026
13 checks passed
@Leonabcd123 Leonabcd123 deleted the bye-jquery-email-handler branch January 6, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants