Closed
Conversation
Contributor
Author
|
@dotnet-policy-service agree company="Verge Aero" |
Collaborator
|
Thanks so much, very nice work. We need to upgrade the CI binary packages as well, that's taken care of by some explicit actions, I'll get them running shortly. |
Fix compile error C2226 in non English locale see: llvm/llvm-project#60549
mitchcapper
added a commit
to mitchcapper/CppSharp
that referenced
this pull request
Oct 1, 2025
allow using older versions of clang than 19 until mono#1942
mitchcapper
added a commit
to mitchcapper/CppSharp
that referenced
this pull request
Oct 1, 2025
allow using older versions of clang than 19 until mono#1942
mitchcapper
added a commit
to mitchcapper/CppSharp
that referenced
this pull request
Oct 1, 2025
allow using older versions of clang than 19 until mono#1942
mitchcapper
added a commit
to mitchcapper/CppSharp
that referenced
this pull request
Oct 17, 2025
allow using older versions of clang than 19 until mono#1942
Collaborator
|
I can't seem to re-run CI on this from the web, can you rebase and update this on latest master so we get fresh builds? |
Collaborator
|
Thanks so much for your contribution @VergeChris. I finally managed to get this one merged, though I had to create another PR to make some changes on top of this: #1949 Hope that's ok with you, you will still get credited on your commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the latest msvc requires Clang >= 19, I went ahead and updated the parser to accomodate the API changes. It compiles and the tests do pass locally on windows. Unsure of the other platforms.
Addresses the issue here
I did use the LLVM commit referenced in that issue [cd70802]
Although I'm actively using CppSharp to a high degree success, this is my first direct dive into LLVM or the CppSharp codebase so I'd be happy to work through any suggested changes.