Fix ParseHeader() can only report the last file's error in non unityBuild mode#1945
Fix ParseHeader() can only report the last file's error in non unityBuild mode#1945zhaojunmeng wants to merge 0 commit intomono:mainfrom
Conversation
It seems that the error that already existed in the previous CI pipeline has been exposed by this merge quest.😭 |
|
@zhaojunmeng Is this fix still necessary? |
I believe this is necessary. When I first used CppSharp, I couldn’t generate the wrapper files for my project because some of the header files I parsed had compilation errors—but the ParseHeader() function only reported the parse result of the last header file (which was successful). This took me one day to identify the actual issue. But I’m having trouble passing the CI action on the Linux platform. I thought the include path isn’t set up correctly on Linux when running Emscripten’s tests for tests/Builtins.h to find cstddef.h and cstdint.h. |
|
Ok, I can try to help and see what's going on. Can you please re-open or send another PR with this fix? |
Thanks, that would be nice! I'll send a new PR for this. |
Change to: if any file has non success ParseResult, just stop parsing and return the result.