Skip to content

Restore successful github action build and nuget package generation#1946

Merged
tritao merged 3 commits intomono:mainfrom
mitchcapper:windows_working
Oct 17, 2025
Merged

Restore successful github action build and nuget package generation#1946
tritao merged 3 commits intomono:mainfrom
mitchcapper:windows_working

Conversation

@mitchcapper
Copy link
Contributor

@mitchcapper mitchcapper commented Oct 1, 2025

If you folks don't want to do the nuget.org upload it might be a good idea to do releases that include the nupkg to make life easier for people:)

Fixes #1940

@tritao
Copy link
Collaborator

tritao commented Oct 17, 2025

Hey @mitchcapper, thanks for the PR and sorry for the delay in getting to it, I just noticed it.

Unfortunately the CI is failing with Unhandled exception: Nerdbank.GitVersioning.GitException: Shallow clone lacks the objects required to calculate version height. Use full clones or clones with a history at least as deep as the last version height resetting change.. Doesn't seem caused by your changes though.

@mitchcapper
Copy link
Contributor Author

Must be some repo env thing oddly as it worked in my original action test: https://github.com/mitchcapper/CppSharp/actions/runs/18149035233

I changed it to force a deep clone (unrelated to my changes I believe) that should fix it here.

AddArguments("-fms-extensions");
AddArguments("-fms-compatibility");
AddArguments("-fdelayed-template-parsing");
AddArguments("-D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to spaces as used in rest of sorrounding lines?

@mitchcapper
Copy link
Contributor Author

Sorry all set:)

@tritao tritao merged commit 3aba55b into mono:main Oct 17, 2025
1 check passed
@perlun
Copy link
Contributor

perlun commented Oct 25, 2025

Thanks for your effort @mitchcapper, nice to see people trying to get this project moving forward. 👍 Unfortunately, the CI/create_package job still seems to fail because of the shallow clone issue. Anything we can do about it?

@mitchcapper
Copy link
Contributor Author

mitchcapper commented Oct 25, 2025

@perlun been a minute, good to see you:) I don't think you can double merge a PR so the fix is in #1948

I have some larger changes coming in the next few weeks specifically around C code conversion and array passing.

@perlun
Copy link
Contributor

perlun commented Oct 28, 2025

Thanks, great to get that issue sorted. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - CppSharp cannot process files with latest MSVC (14.44.35207) STL

3 participants