Skip to content

Fixed SKGLView on Android not being rendered when using a TabBar #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed SKGLView on Android not being rendered when using a TabBar #3076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions source/SkiaSharp.Views/SkiaSharp.Views/Platform/Android/GLTextureView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public void SetRenderer(IRenderer renderer)
eglWindowSurfaceFactory = new DefaultWindowSurfaceFactory();
}
this.renderer = renderer;
glThread = new GLThread(thisWeakRef);
glThread = new GLThread(thisWeakRef, Width, Height);
glThread.Start();
}

Expand Down Expand Up @@ -211,7 +211,7 @@ protected override void OnAttachedToWindow()
{
renderMode = glThread.GetRenderMode();
}
glThread = new GLThread(thisWeakRef);
glThread = new GLThread(thisWeakRef, Width, Height);
if (renderMode != Rendermode.Continuously)
{
glThread.SetRenderMode(renderMode);
Expand Down Expand Up @@ -713,12 +713,12 @@ private class GLThread
private bool surfaceSizeChanged = true;
// End of member variables protected by the sGLThreadManager monitor.

public GLThread(WeakReference<GLTextureView> glTextureViewWeakRef)
public GLThread(WeakReference<GLTextureView> glTextureViewWeakRef, int initialWidth, int initialHeight)
{
threadManager = new GLThreadManager();

width = 0;
height = 0;
width = initialWidth;
height = initialHeight;
requestRender = true;
renderMode = Rendermode.Continuously;
textureViewWeakRef = glTextureViewWeakRef;
Expand Down