Skip to content

Fixes WPF SKGLElement has memory leaks #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes WPF SKGLElement has memory leaks #3311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d0f53
Update OpenTK
beto-rodriguez Jul 19, 2025
cc7256b
Dispose GLWpfControl when SKGLElement is disposed
beto-rodriguez Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/SkiaSharp.Views/SkiaSharp.Views.WPF/SKGLElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,15 @@ private void Release()
public void Dispose()
{
Dispose(true);

#if NET6_0_OR_GREATER
base.Dispose();
#else
// Older version of OpenTK do not implement IDisposable
// And there is also a possible memory leak in the base class
// https://github.com/opentk/GLWpfControl/issues/126
// ToDo: Update OpenTK? manually dispose the base class?
#endif
}
}

Expand Down
4 changes: 2 additions & 2 deletions source/SkiaSharp.Views/SkiaSharp.Views.WPF/SkiaSharp.Views.WPF.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
<PackageReference Include="OpenTK.GLWpfControl" Version="3.3.0" NoWarn="NU1701" />
</ItemGroup>
<ItemGroup Condition="!$(TargetFramework.StartsWith('net4'))">
<PackageReference Include="OpenTK" Version="4.3.0" NoWarn="NU1701" />
<PackageReference Include="OpenTK.GLWpfControl" Version="4.2.3" />
<PackageReference Include="OpenTK" Version="4.9.4" NoWarn="NU1701" />
<PackageReference Include="OpenTK.GLWpfControl" Version="4.3.3" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\binding\SkiaSharp\SkiaSharp.csproj" />
Expand Down