Merge pull request #92 from JetBrains/onRunProperExceptionHandling

Handling exceptions in OnRun() before ForceExit

Author: David Karlaš

Mono.Debugging/Mono.Debugging.Client/DebuggerSession.cs

@@ -328,8 +328,10 @@ public void Run (DebuggerStartInfo startInfo, DebuggerSessionOptions options)
 					try {
 						OnRun (startInfo);
 					} catch (Exception ex) {
+						// should handle exception before raising Exit event because HandleException may ignore exceptions in Exited state
+						var exceptionHandled = HandleException (ex);
 						ForceExit ();
-						if (!HandleException (ex))
+						if (!exceptionHandled)
 							throw;
 					}
 				});
@@ -363,8 +365,10 @@ public void AttachToProcess (ProcessInfo proc, DebuggerSessionOptions options)
 						OnAttachToProcess (proc.Id);
 						attached = true;
 					} catch (Exception ex) {
+						// should handle exception before raising Exit event because HandleException may ignore exceptions in Exited state
+						var exceptionHandled = HandleException (ex);
 						ForceExit ();
-						if (!HandleException (ex))
+						if (!exceptionHandled)
 							throw;
 					}
 				});
@@ -509,8 +513,10 @@ public void Finish ()
 					try {
 						OnFinish ();
 					} catch (Exception ex) {
+						// should handle exception before raising Exit event because HandleException may ignore exceptions in Exited state
+						var exceptionHandled = HandleException (ex);
 						ForceExit ();
-						if (!HandleException (ex))
+						if (!exceptionHandled)
 							throw;
 					}
 				});