Skip to content

Support click house as data source #202#209

Open
dougkamp wants to merge 6 commits intomonosidev:developfrom
dougkamp:Support-ClickHouse-as-data-source-#202
Open

Support click house as data source #202#209
dougkamp wants to merge 6 commits intomonosidev:developfrom
dougkamp:Support-ClickHouse-as-data-source-#202

Conversation

@dougkamp
Copy link

@dougkamp dougkamp commented Sep 11, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • [ X] Feature
  • Other (please describe):

Issue

Resolves #202

Description of change & new behavior

Now adds support for ClickHouse data warehouse (needs further work - see below)

Screenshots

For frontend updates, please include a screenshot.

Technical Spec/Implementation Notes

Implements ClickHouse DW support using clickhouse-sqlalchemy package.

Note: I have been unable to get a successful connection on my local dev PC running ClickHouse in Docker as a container. I have spent many hours trying to work out why and at this stage I am stuck. I am not sure if its a local dev environment issue, a driver (clickhouse-sqlalchemy) issue, a bug or some combination of some or all of these. It needs someone more familiar with ClickHouse and SqlAlchemy to nut this one out unfortunately

Please check if your PR fulfills the following requirements:

  • If it's a backend change, tests for the changes have been added and run successfully.
  • If it's a frontend change, Prettier has been run & all tests pass

@Slach
Copy link

Slach commented Sep 11, 2022

@dougkamp i can help with docker + clickhouse
could you provide more context and share error messages?
i don't see any changes in docker-compose related files which will try to clickhouse service

@dougkamp
Copy link
Author

Hi @Slach Thanks for the offer but i have just managed to get it working. It was a Docker networking config error in my ClickHouse container when i set it up (i wasn't correctly mapping the internal port to the external port i needed to connect).

Now i just need to fix the SQL errors I am getting for all the measure and should be good to go.

@iporollo iporollo changed the base branch from master to develop September 18, 2022 20:59
Copy link
Contributor

@iporollo iporollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, looks good to me

@iporollo iporollo requested a review from unkrich September 18, 2022 21:03
@dougkamp
Copy link
Author

Some fixes to Clickhouse support addressing issues found during testing of metrics queries as Clcikhouse internal table structure and SQL query syntax is quite different to MS SQL, PostgreSQL etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ClickHouse as data source

3 participants