Skip to content

fix(security): CVE-HSYNC-2026-003 - Enforce RPC authentication #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monteslu merged 2 commits into from
Feb 12, 2026
+11 −1
Merged

fix(security): CVE-HSYNC-2026-003 - Enforce RPC authentication #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42acaf
fix(security): enforce RPC authentication validation
monteslu Feb 7, 2026
c063e99
fix: remove auth tokens from debug output (Luthien review)
monteslu Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,20 @@ export async function createHsync(config) {
getSocketRelays: hsyncClient.getSocketRelays,
peerRpc: async (requestInfo) => {
requestInfo.hsyncClient = hsyncClient;
const { msg } = requestInfo;
const { msg, myAuth } = requestInfo;
debug('peerRpc handler', requestInfo.fromHost, msg.method);
const peer = hsyncClient.peers.getRPCPeer({ hostName: requestInfo.fromHost, hsyncClient });
requestInfo.peer = peer;

// Security: Validate authentication token before processing any RPC request
// CVE-HSYNC-2026-003: Previously, myAuth was sent but never verified
if (peer.myAuth !== myAuth) {
debug('peerRpc auth failed', requestInfo.fromHost, myAuth ? 'invalid token' : 'missing token');
const authError = new Error('RPC authentication failed: invalid or missing auth token');
authError.code = 401;
throw authError;
}

if (!msg.id) {
// notification
if (Array.isArray(msg.params)) {
Expand Down