Skip to content

Conversation

@NeillM
Copy link
Contributor

@NeillM NeillM commented Aug 23, 2024

It appears that this is not clear to everyone who reads the documentation at the moment that a plugin that sends data to a subsystem, for example the logs should not use the null_provider and that the sub-system will do the retrieval and deletion of the personal data.

@netlify
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fbad9d8
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/67064707122cbb0008d66879
😎 Deploy Preview https://deploy-preview-1105--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NeillM
Copy link
Contributor Author

NeillM commented Aug 23, 2024

The lighthosue test seems to have failed while waiting for an external site to build something (I'm guessing the docs), is that likely to just be that tool/website being slow when this ran?

From looking at the test I am not certain that there is anything I can do about that one.

@NeillM
Copy link
Contributor Author

NeillM commented Aug 23, 2024

I realised that I should probably modify the docs for all versions of Moodle

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 80 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 71 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 76 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 66 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a minor change to the display of code and a clarification where the get_metadata() method that needs to be implemented is.

@NeillM
Copy link
Contributor Author

NeillM commented Oct 9, 2024

Thanks for the feedback I have implemented the changes

It appears that this is not clear to everyone who reads the documentation at
the moment that a plugin that sends data to a subsystem, for example the
logs should not use the null_provider and that the sub-system will do the
retrieval and deletion of the personal data.

This has been the case in all versions of Moodle supported by the dev docs.
@NeillM
Copy link
Contributor Author

NeillM commented Oct 9, 2024

The spelling error appears to be unconnected to this change, it seems to be talking about line 112 of the ai placements documentation (which is odd since that word does not appear on that line)

Issues found:
./docs/apis/plugintypes/ai/placement.md:112:90 - Unknown word (settingspage)
CSpell: Files checked: 498, Issues found: 1 in 1 file.

@NeillM
Copy link
Contributor Author

NeillM commented Oct 9, 2024

I have rebased it onto the latest changes to see if that fixes it.

@andrewnicols
Copy link
Member

Thanks. I have a fix for that in another issue up for PR

@andrewnicols andrewnicols enabled auto-merge October 9, 2024 09:17
@andrewnicols andrewnicols added this pull request to the merge queue Oct 9, 2024
Merged via the queue into moodle:main with commit 7a34f71 Oct 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants