Skip to content

Conversation

@kabalin
Copy link
Collaborator

@kabalin kabalin commented Oct 18, 2024

Adding checklist item to remember about bumping moodle-plugin-ci test matrix (as discussed with @junpataleta)

@netlify
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 41b3808
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/671774387fe901000889a8cc
😎 Deploy Preview https://deploy-preview-1161--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 45 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🔴 43 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 58 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 64 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Collaborator

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to perform this task for the minor release cycle as well, so I'd like to ask for some clarification and pros/cons of doing it during minor releases as well instead of only major releases.

Copy link
Collaborator

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to go now!

@junpataleta junpataleta enabled auto-merge October 22, 2024 09:47
@junpataleta junpataleta added this pull request to the merge queue Oct 22, 2024
Merged via the queue into moodle:main with commit 154fe13 Oct 22, 2024
6 of 7 checks passed
@kabalin kabalin deleted the kabalin-patch-1 branch October 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants