Skip to content

[docs] Documentation for MDL-81825 #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

[docs] Documentation for MDL-81825 #1182

merged 1 commit into from
Dec 12, 2024

Conversation

@roland04
Copy link
Collaborator

@roland04 roland04 commented Nov 11, 2024

@roland04 roland04 added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Nov 11, 2024
@roland04 roland04 self-assigned this Nov 11, 2024
@netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 739d53d
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6759a39ea7a62200085515d6
😎 Deploy Preview https://deploy-preview-1182--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roland04 roland04 force-pushed the devdocs-bootstrap-sronly branch from 423e8cb to dd31ff6 Compare November 11, 2024 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 55 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🟠 62 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 53 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 53 🟢 95 🟢 100 🟢 100 🟢 100 Report

@roland04 roland04 force-pushed the devdocs-bootstrap-sronly branch from dd31ff6 to 37ad7a8 Compare November 11, 2024 15:22
@HuongNV13 HuongNV13 self-requested a review December 11, 2024 02:45
HuongNV13
HuongNV13 reviewed Dec 11, 2024
View reviewed changes
HuongNV13
HuongNV13 requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@HuongNV13 HuongNV13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @roland04,
It looks good to me.
I'd suggest adding code tag to the renamed classes to make them clearer.
Thanks,

@roland04 roland04 force-pushed the devdocs-bootstrap-sronly branch from 37ad7a8 to 739d53d Compare December 11, 2024 14:37
@roland04 roland04 requested a review from HuongNV13 December 11, 2024 15:04
@HuongNV13 HuongNV13 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into moodle:main with commit 8bb3214 Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuongNV13 HuongNV13 HuongNV13 approved these changes

Assignees

@roland04 roland04

Labels

blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roland04 @HuongNV13