MDL-83888 new overview redirection and renderer helper #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranrecio
added
the
blocked-by-tracker
❌ Deploy Preview for moodledevdocs failed.Built without sensitive environment variables
|
ferranrecio
force-pushed
the
MDL-83888-main
branch
from
6ae76a3 to
163e069
Compare
ferranrecio
force-pushed
the
MDL-83888-main
branch
from
163e069 to
c6b662f
Compare
sarjona
removed
the
blocked-by-tracker
sarjona
requested changes
Feb 28, 2025
Member
sarjona
left a comment
sarjona
left a comment
There was a problem hiding this comment.
Hi @ferranrecio!
Thanks for working on the devdocs for https://tracker.moodle.org/browse/MDL-83888 :-)
They look good but, as you'll see, there are some inconsistencies between them and the code that should be reviewed...
sarjona
approved these changes
Mar 5, 2025
Member
sarjona
left a comment
sarjona
left a comment
There was a problem hiding this comment.
Thanks for reviewing and improving the patch to make it clearer. Well done!
I'm happy to approve this pull request! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the patch on MDL-83888.