Skip to content

Conversation

@andrewnicols
Copy link
Member

This changset also adds the ability to hide dates so that we can have them in the calendar but not visible just yet.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a hidden property to the supported release dates and implements logic to filter them out from display.

  • Added an optional "hidden" boolean property to the majorVersionData interface in SupportedReleases.ts
  • Updated SupportedReleases/index.tsx to filter out releases marked as hidden before processing for display

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
src/utils/SupportedReleases.ts Added the optional "hidden" property to the release data structure.
src/components/SupportedReleases/index.tsx Implemented a filter to exclude releases flagged as hidden from the display.
Files not reviewed (2)
  • data/versions.json: Language not supported
  • static/schema/versions.json: Language not supported

@netlify
Copy link

netlify bot commented May 5, 2025

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 8faa095
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6818720fea74bb0008314fbe
😎 Deploy Preview https://deploy-preview-1345--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols andrewnicols force-pushed the 50xreleaseDates branch 2 times, most recently from a7073eb to 57160df Compare May 5, 2025 05:46
@abgreeve
Copy link
Contributor

abgreeve commented May 5, 2025

Hi Andrew,
All of the dates for the releases look accurate. Updating the security date for 5.1 should probably have a wider conversation and separate issue.

I haven't done a pull request for docs in ages and this says there is a conflict with versions.json. Can you let me know if / when this is okay to merge?

Copy link
Contributor

@abgreeve abgreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment already made.

Whilst release dates have been confirmed, the general support end date,
and security support end date have yet to be confirmed.
@andrewnicols
Copy link
Member Author

Should be good to merge. No conflicts (andi t was able to self-rebase). You shoudl be able to just select "Merge when ready"

@andrewnicols andrewnicols added this pull request to the merge queue May 6, 2025
Merged via the queue into moodle:main with commit 7bf4004 May 6, 2025
6 checks passed
@andrewnicols andrewnicols deleted the 50xreleaseDates branch May 6, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants