-
Notifications
You must be signed in to change notification settings - Fork 498
5.x Release dates #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.x Release dates #1345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a hidden property to the supported release dates and implements logic to filter them out from display.
- Added an optional "hidden" boolean property to the majorVersionData interface in SupportedReleases.ts
- Updated SupportedReleases/index.tsx to filter out releases marked as hidden before processing for display
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/SupportedReleases.ts | Added the optional "hidden" property to the release data structure. |
| src/components/SupportedReleases/index.tsx | Implemented a filter to exclude releases flagged as hidden from the display. |
Files not reviewed (2)
- data/versions.json: Language not supported
- static/schema/versions.json: Language not supported
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a7073eb to
57160df
Compare
|
Hi Andrew, I haven't done a pull request for docs in ages and this says there is a conflict with versions.json. Can you let me know if / when this is okay to merge? |
abgreeve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment already made.
Whilst release dates have been confirmed, the general support end date, and security support end date have yet to be confirmed.
57160df to
8faa095
Compare
|
Should be good to merge. No conflicts (andi t was able to self-rebase). You shoudl be able to just select "Merge when ready" |
This changset also adds the ability to hide dates so that we can have them in the calendar but not visible just yet.