MDLSITE-7941 MDLSITE-7956: Improve waffle menu title and top bar site indication #1347
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the navigation bar to improve consistency and accessibility across Moodle community environments. The changes include highlighting the current page in the menu and updating the waffle menu toggle to better indicate its purpose.
- Updated the "Development" link by applying an active style to its text
- Revised the waffle menu toggle button by changing its aria-label and adding a title attribute
Files not reviewed (1)
- src/theme/Navbar/index.module.css: Language not supported
Comments suppressed due to low confidence (1)
src/theme/Navbar/index.js:123
- Consider adding an aria-expanded attribute to this toggle button to reflect its open/closed state for improved accessibility.
onClick={() => openMenu('waffle_menu')}
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarjona
left a comment
sarjona
left a comment
There was a problem hiding this comment.
Hola @durenadev!
Thanks for working on this. It's great to get consistency along these pages <3
The way for highlighting the current page looks different to other Moodle pages (slightly up). The same happens when hovering these links:
Could you take a look at improve these CSS styles? TIA
durenadev
force-pushed
the
MDLSITE-7941-7956
branch
from
fea436c to
c49ff59
Compare
|
Hola @sarjona! I've modified the CSS to better match the height and colour of this environment with that of moodle.org. |
sarjona
left a comment
sarjona
left a comment
There was a problem hiding this comment.
Hi @durenadev!
Thanks a lot for reviewing the patch. It looks better now so I'm happy to approve and merge it :-)
2 participants
Hi,
According to the Moodle sites issues:
I applied the necessary changes to keep the top bar consistent across all community environments and highlight the current page in the menu. Additionally, I am improving accessibility in the waffle menu.