Skip to content

Add unserialize() method to danger list. #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add unserialize() method to danger list. #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions general/development/policies/codingstyle/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2073,6 +2073,7 @@ PHP includes multiple questionable features that are highly discouraged because
1. do not use `preg_replace()` with /e modifier - use callbacks in order to prevent unintended PHP execution.
1. do not use backticks for shell command execution.
1. do not use `goto`, neither the operator neither labels - use other programming techniques to control the execution flow.
1. do not use `unserialize`, can lead to unintended PHP execution if not used properly with user supplied data - there are better methods of data exchange.

## Policy about coding-style only fixes

Expand Down