Performance testing base branch by lameze · Pull Request #166 · moodlehq/moodle-ci-runner

lameze · 2026-01-30T08:08:12Z

First chuck of work to restore the performance job in our CI.

Probably there are some things that needs to be improved/fixed here and there but this is running in our CI without problems.

This commit also tidy up and fixes some minor issues.

codecov-commenter · 2026-01-30T08:11:26Z

Codecov Report

❌ Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.07%. Comparing base (59e41cf) to head (de330f6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
runner/main/jobtypes/performance/performance.sh	0.00%	126 Missing ⚠️
runner/main/modules/docker-jmeter/docker-jmeter.sh	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   63.15%   61.07%   -2.08%     
==========================================
  Files          51       56       +5     
  Lines        1699     2130     +431     
==========================================
+ Hits         1073     1301     +228     
- Misses        626      829     +203

Flag	Coverage Δ
behat_bisect_test	`37.96% <0.00%> (-2.36%)`	⬇️
behat_test	`39.43% <0.00%> (-1.31%)`	⬇️
phpunit_bisect_test	`31.23% <0.00%> (-2.96%)`	⬇️
phpunit_test	`31.84% <0.00%> (-2.58%)`	⬇️
postjobs_test	`28.10% <0.00%> (-4.84%)`	⬇️
runner_test	`14.31% <0.00%> (-1.58%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

andrewnicols · 2026-02-02T02:47:36Z

runner/main/jobtypes/performance/performance.sh

+    chmod -R 2777 "${SHAREDDIR}" || true
+
+    # Clone the performance data generator plugin inside the container.
+    docker exec "${WEBSERVER}" sh -c "git clone --depth 1 ${plugin_repo} ${dest}"


Why are we doing it this way? See the plugins module
https://github.com/moodlehq/moodle-ci-runner/blob/main/runner/main/modules/plugins/plugins.sh#L21

Essentially we shoudl be setting the PLUGINSTOINSTALL to something like:

PLUGINSTOINSTALL="${PLUGINSTOINSTALL};$plugin_repo|local/performancetool|main"

I have updated the runner code to use the PLUGINSTOINSTALL

andrewnicols · 2026-02-02T02:47:52Z

runner/main/jobtypes/performance/performance.sh

+    echo "Running: ${initcmd[*]}"
+
+    plugin_repo="https://github.com/moodlehq/moodle-local_performancetool"
+    dest="/var/www/html/local/performancetool"


This won't work for Moodle 5.1 and above -- it isn't in the public directory.

Good catch, fixed.

andrewnicols · 2026-02-02T02:48:29Z

runner/main/jobtypes/performance/performance.sh

+    local initcmd
+    performance_initcmd initcmd # By nameref.
+    echo "Running: ${initcmd[*]}"


This should be just above the actual cal to the command, otherwise it can make debugging very confusing.

I have done a big clean up, it should be all good now.

andrewnicols · 2026-02-02T02:48:53Z

runner/main/jobtypes/performance/performance.sh

+
+    # Ensure host shared directories exist and are writable so plugin can save files.
+    mkdir -p "${SHAREDDIR}/planfiles" "${SHAREDDIR}/output/logs" "${SHAREDDIR}/output/runs"
+    chmod -R 2777 "${SHAREDDIR}" || true


What's this about? Why do we need || true?

andrewnicols · 2026-02-02T02:52:49Z

runner/main/jobtypes/performance/performance.sh

+    echo "Copying generated plan files from container to ${SHAREDDIR}/planfiles"
+
+    docker exec -u root "${WEBSERVER}" bash -lc "\
+      mkdir -p /shared/planfiles && \


Didn't we already do this a few lines above? (the mkdir)?

andrewnicols · 2026-02-02T03:10:19Z

runner/main/jobtypes/performance/performance.sh

+            --size="${SITESIZE}" \
+            --fixeddataset \
+            --bypasscheck \
+            --filesizelimit="1000"


What is the file size limit? Should it be in env vars?

andrewnicols · 2026-02-02T03:11:08Z

runner/main/modules/docker-jmeter/libraries/recorder.bsf

@@ -0,0 +1,219 @@
+import java.io.*;


What is this, and where is it used? Didn't we copy this into the performance tool system itself? I can't see anywhere that we consume this file.

andrewnicols · 2026-02-02T03:11:41Z

runner/main/modules/docker-jmeter/libraries/recorderfunctions.bsf

@@ -0,0 +1,12 @@
+import java.io.*;


Ditto this file. Can't see it being used anywere right now.

andrewnicols · 2026-02-02T03:12:26Z

runner/main/jobtypes/performance/performance.sh

+    # Include logs string.
+    includelogs=1
+    includelogsstr="-Jincludelogs=$includelogs"
+    samplerinitstr="-Jbeanshell.listener.init=recorderfunctions.bsf"


Ah - just found where we're using the recorder. Is this something that can / should be in the jmx files themselves?

andrewnicols · 2026-02-02T03:13:59Z

runner/main/modules/docker-php/config.template.php

 $CFG->skiplangupgrade = false;

-$CFG->wwwroot   = 'http://host.name';
+$CFG->wwwroot   = getenv('MOODLE_WWWROOT') ?: 'http://host.name';


What's the purpose of this change?

Without this change the following error is displayed during the Jmeter run:
| http://host.name/course/view.php?id=4 Non HTTP response code: java.net.UnknownHostException | 3

andrewnicols and others added 2 commits January 30, 2026 10:49

Implement a new performance job type

69a3e8b

Update runner to use the new performancetool plugin

8daa21c

This commit also tidy up and fixes some minor issues.

github-actions bot assigned lameze Jan 30, 2026

andrewnicols requested changes Feb 2, 2026

View reviewed changes

lameze force-pushed the performanceTestingOficial branch from 2ba68c8 to 8daa21c Compare February 19, 2026 02:12

lameze added 2 commits February 19, 2026 13:34

Update runner to install performancetool using PLUGINSTOINSTALL

5c8b221

Code clean up

de330f6

Conversation

lameze commented Jan 30, 2026

Uh oh!

codecov-commenter commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Jan 30, 2026 •

edited

Loading