MOBILE-1581 quiz: Fix offline status calculation errors

Author: dpalou

www/addons/qbehaviour/deferredfeedback/handlers.js

@@ -74,8 +74,10 @@ angular.module('mm.addons.qbehaviour_deferredfeedback')
 
             // Answers have changed.
             if (typeof isComplete == 'function') {
-                complete = isComplete(question, newBasicAnswers);
+                // Pass all the answers since some behaviours might need the extra data.
+                complete = isComplete(question, question.answers);
             } else {
+                // Only pass the basic answers since questions should be independent of extra data.
                 complete = $mmQuestion.isCompleteResponse(question, newBasicAnswers);
             }
 

www/addons/qbehaviour/informationitem/handlers.js

@@ -21,10 +21,29 @@ angular.module('mm.addons.qbehaviour_informationitem')
  * @ngdoc service
  * @name $mmaQbehaviourInformationItemHandler
  */
-.factory('$mmaQbehaviourInformationItemHandler', function($mmQuestionHelper) {
+.factory('$mmaQbehaviourInformationItemHandler', function($mmQuestionHelper, $mmQuestion) {
 
     var self = {};
 
+    /**
+     * Determine a question state based on its answer(s).
+     *
+     * @param  {String} component      Component the question belongs to.
+     * @param  {Number} attemptId      Attempt ID the question belongs to.
+     * @param  {Object} question       The question.
+     * @param  {String} [siteId]       Site ID. If not defined, current site.
+     * @param  {Function} [isComplete] To override the default isCompleteResponse check. Optional.
+     * @param  {Function} [isSame]     To override the default isSameResponse check. Optional.
+     * @return {Promise}               Promise resolved with the state or false if cannot determine state.
+     */
+    self.determineQuestionState = function(component, attemptId, question, siteId, isComplete, isSame) {
+        if (question.answers['-seen']) {
+            return $mmQuestion.getState('complete');
+        }
+
+        return false;
+    };
+
     /**
      * Whether or not the module is enabled for the site.
      *

www/addons/qbehaviour/manualgraded/handlers.js

@@ -21,10 +21,78 @@ angular.module('mm.addons.qbehaviour_manualgraded')
  * @ngdoc service
  * @name $mmaQbehaviourManualGradedHandler
  */
-.factory('$mmaQbehaviourManualGradedHandler', function() {
+.factory('$mmaQbehaviourManualGradedHandler', function($mmQuestion) {
 
     var self = {};
 
+    /**
+     * Determine a question state based on its answer(s).
+     *
+     * @param  {String} component      Component the question belongs to.
+     * @param  {Number} attemptId      Attempt ID the question belongs to.
+     * @param  {Object} question       The question.
+     * @param  {String} [siteId]       Site ID. If not defined, current site.
+     * @param  {Function} [isComplete] To override the default isCompleteResponse check. Optional.
+     * @param  {Function} [isSame]     To override the default isSameResponse check. Optional.
+     * @return {Promise}               Promise resolved with the state or false if cannot determine state.
+     */
+    self.determineQuestionState = function(component, attemptId, question, siteId, isComplete, isSame) {
+        // Check if we have local data for the question.
+        return $mmQuestion.getQuestion(component, attemptId, question.slot, siteId).catch(function() {
+            // No entry found, use the original data.
+            return question;
+        }).then(function(dbQuestion) {
+            var state = $mmQuestion.getState(dbQuestion.state);
+
+            if (state.finished || !state.active) {
+                // Question is finished.
+                return false;
+            }
+
+            // We need to check if the answers have changed. Retrieve current stored answers.
+            return $mmQuestion.getQuestionAnswers(component, attemptId, question.slot, false, siteId);
+        }).then(function(prevAnswers) {
+            var complete,
+                newState,
+                prevBasicAnswers,
+                newBasicAnswers = $mmQuestion.getBasicAnswers(question.answers);
+
+            prevAnswers = $mmQuestion.convertAnswersArrayToObject(prevAnswers);
+            prevBasicAnswers = $mmQuestion.getBasicAnswers(prevAnswers);
+
+            // Check if answers haven't changed.
+            if (typeof isSame == 'function') {
+                if (isSame(question, prevAnswers, prevBasicAnswers, question.answers, newBasicAnswers)) {
+                    return false;
+                }
+            } else {
+                if ($mmQuestion.isSameResponse(question, prevBasicAnswers, newBasicAnswers)) {
+                    return false;
+                }
+            }
+
+            // Answers have changed.
+            if (typeof isComplete == 'function') {
+                // Pass all the answers since some behaviours might need the extra data.
+                complete = isComplete(question, question.answers);
+            } else {
+                // Only pass the basic answers since questions should be independent of extra data.
+                complete = $mmQuestion.isCompleteResponse(question, newBasicAnswers);
+            }
+
+            if (complete == -1) {
+                newState = 'unknown';
+            } else if (complete) {
+                newState = 'complete';
+            } else {
+                newState = 'todo';
+            }
+
+            return $mmQuestion.getState(newState);
+
+        });
+    };
+
     /**
      * Whether or not the module is enabled for the site.
      *

www/addons/qtype/essay/handlers.js

@@ -25,6 +25,17 @@ angular.module('mm.addons.qtype_essay')
 
     var self = {};
 
+    /**
+     * Get the behaviour for this question.
+     *
+     * @param  {Object} question  Question to get the directive for.
+     * @param  {String} behaviour Default behaviour.
+     * @return {String}           Behaviour name.
+     */
+    self.getBehaviour = function(question, behaviour) {
+        return 'manualgraded';
+    };
+
     /**
      * Check if a response is complete.
      *