MOBILE-4595: WCAG 2.1 AA accessibility accreditation for version 4.5#4291
Merged
dpalou merged 44 commits intomoodlehq:mainfrom Jan 22, 2025
Merged
MOBILE-4595: WCAG 2.1 AA accessibility accreditation for version 4.5#4291dpalou merged 44 commits intomoodlehq:mainfrom
dpalou merged 44 commits intomoodlehq:mainfrom
Conversation
dpalou
requested changes
Jan 21, 2025
src/core/features/courses/components/course-list-item/core-courses-course-list-item.html
Outdated
Show resolved
Hide resolved
src/addons/storagemanager/pages/course-storage/course-storage.ts
Outdated
Show resolved
Hide resolved
A bug in Ionic prevents focusings buttons inside ion-input components: it sets the focus to the input element when any element inside the component is focused.
The behaviour is now consistent with clicks triggered by keyboard.
Screen readers do not support having semantic elements inside buttons. Now, the button to access a course includes only the course name, rather than the entire content of the card. The card remains fully clickable, with no visual changes. Additionally, the semantic order of elements has been changed so that the menu button is traversed after other content in the card.
Screen readers do not support having semantic elements inside buttons. Now, the button to access a module includes only the title, rather than the entire content of the card. The card remains fully clickable, with no visual changes.
Focus trap does not work correctly in Ionic when the modal contains hidden focusable elements, such as the back button.
Screen readers do not support having semantic elements inside buttons. Now, the button to access a section includes only the section name, rather than the entire content of the item. The item remains fully clickable, with no visual changes.
The resize handle is confusing because the course index modal cannot be resized, only closed.
Screen readers do not support having semantic elements inside buttons. Now, the button to dowload a file includes only the file name, rather than the entire content of the item. The item remains fully clickable, with no visual changes.
Screen readers do not support having semantic elements inside buttons. Now, the button to open forum discussions includes only the subject, rather than the entire content of the item. The item remains fully clickable, with no visual changes.
The button label was stuck at "Downloading" after the download finished or was cancelled.
Display a blue outline on focused buttons instead of changing the background color, which caused color contrast issues.
CSS variables `--highlight-color-valid` and `--highlight-color-invalid` has been removed from item component in Ionic 8.
The behaviour of ion-radio and ion-checkbox elements with links is wrong: they can be clicked but the focus and the ripple effect are not displayed. It can only be fixed by patching Ionic.
We cannot use ion-accordion because the header is always a button and screen readers do not support having semantic elements inside buttons.
albertgasset
force-pushed
the
MOBILE-4595
branch
from
c2da634 to
6fa9d50
Compare
dpalou
approved these changes
Jan 22, 2025
ali205412
pushed a commit
to ali205412/moodleapp
that referenced
this pull request
Jan 26, 2026
MOBILE-4595: WCAG 2.1 AA accessibility accreditation for version 4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.