MOBILE-5013 h5pactivity: Ignore error when post state & statements#4731
Open
alfonso-salces wants to merge 1 commit intomoodlehq:mainfrom
Open
MOBILE-5013 h5pactivity: Ignore error when post state & statements#4731alfonso-salces wants to merge 1 commit intomoodlehq:mainfrom
alfonso-salces wants to merge 1 commit intomoodlehq:mainfrom
Conversation
alfonso-salces
force-pushed
the
MOBILE-5013
branch
from
0218c32 to
755f7fe
Compare
There was a problem hiding this comment.
Pull request overview
This PR (MOBILE-5013) updates the H5P activity index component to stop surfacing user-facing alerts when xAPI tracking “post state” / “post statements” fails, and instead silently ignores those failures.
Changes:
- Add a logger instance to the H5P activity index component.
- Replace
CoreAlerts.showError(...)calls withlogger.error(...)inpostStatementsandpostStateerror paths.
alfonso-salces
force-pushed
the
MOBILE-5013
branch
from
755f7fe to
7b9e409
Compare
alfonso-salces
force-pushed
the
MOBILE-5013
branch
from
7b9e409 to
ac273cd
Compare
dpalou
requested changes
Feb 26, 2026
| protected messageListenerFunction: (event: MessageEvent) => Promise<void>; | ||
| protected checkCompletionAfterLog = false; // It's called later, when the user plays the package. | ||
| protected offlineErrorAlert: HTMLIonAlertElement | null = null; | ||
| protected activityLogger: CoreLogger; |
Contributor
There was a problem hiding this comment.
As mentioned by a Copilot comment, a logger is already created in the super class (CoreCourseModuleMainResourceComponent). There is no need to create a new logger, you can use the existing one by using "this.logger".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.