MOBILE-5015 loading: Workaround to fix animation.leave not firing#4733
Merged
dpalou merged 2 commits intomoodlehq:mainfrom Feb 26, 2026
Merged
MOBILE-5015 loading: Workaround to fix animation.leave not firing#4733dpalou merged 2 commits intomoodlehq:mainfrom
dpalou merged 2 commits intomoodlehq:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a workaround for an Angular animation issue introduced in version 20.3.6 where the animation.leave event is not firing correctly. The fix manually emulates the leave animation by adding a CSS class and removing the element after the animation completes, targeting the core-loading component specifically.
Changes:
- Added a workaround in the core-loading component to manually trigger the hide animation and remove the loading container element after 500ms
- Included a TODO comment indicating this should be removed when updating to Angular v21
crazyserver
force-pushed
the
MOBILE-5015
branch
from
2fbb29b to
0c6c884
Compare
dpalou
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://moodle.atlassian.net/browse/MOBILE-5015
Problem was introduced when changing the animation scheduling here: . We’ve testing this is solved by reverting to 20.3.5 or updating angular to 21.2.0.
We’ve decided to make a workaround just to solve the issue in core-loading.