Stop IDEs getting confused by multiple definitions of moodleform_mod#52
Open
davosmith wants to merge 1 commit intomoodleou:masterfrom
Open
Stop IDEs getting confused by multiple definitions of moodleform_mod#52davosmith wants to merge 1 commit intomoodleou:masterfrom
davosmith wants to merge 1 commit intomoodleou:masterfrom
Conversation
Contributor
Author
|
I wondered if there was any chance of this change being integrated? It does make development of other activity modules more difficult when mod_oublog is present on a site. |
Member
|
Davo, thanks for this - I hadn't totally forgotten to add this into our codebase, honest (I just hadn't got round to it after a year - so maybe that is the same thing as forgetting!). I will try and remember to merge for our next release... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is breaking autocompletion in PHPStorm on moodleform_mod forms throughout the codebase I am working with. This is due to there being multiple definitions of moodleform_mod.
This alternative implementation prevents that from happening.