refactor: move EventTarget to internal package#855
Draft
tonyfettes wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Packages other than
agentneeds to emit/receive their own event too, for example:cmd/test, for emitting system informations like model, system promptcmd/serverandcmd/daemon, for emitting synchronization event, status event, etc. Seedaemon_test.mbtandserver_test.mbton more detail on their customized event other than events emitted from agent.Therefore, if we could generialize the underlying
emit/add_listenermechanism, we can use the same data structure across all these packages, improving the uniformity of coding style, reducing code duplication.Changes
This PR extract the "pure control flow" part of the logic from
@event.EventTarget, and place it intointernal/event_target, and thus making it a generic typeEventTarget[T]whereTis anything that consumer may want to passing around using such data structure.This refactor does not directly remove the
@event.EventTarget, but instead making it a simple wrapper over@internal/event_target.EventTarget[Event]to provider easier event emitting, etc.