Support RGB colorspaces and explicit tone mapping#126
Draft
ns6089 wants to merge 2 commits intomoonlight-stream:masterfrom
Draft
Support RGB colorspaces and explicit tone mapping#126ns6089 wants to merge 2 commits intomoonlight-stream:masterfrom
ns6089 wants to merge 2 commits intomoonlight-stream:masterfrom
Conversation
ns6089
commented
Feb 18, 2026
| // If not set and selected format is 10-bit, HDR content will be encoded as is. | ||
| // The reason behind this field is the ambiguity of 'supportedVideoFormats', | ||
| // as it's impossible to request 10-bit tone mapped content through that field alone. | ||
| int toneMapHDR; |
Contributor
Author
There was a problem hiding this comment.
Not sure which one is better, pushing like this or pulling through renderer capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's here as a placeholder for the most part, but comments are always appreciated.
There's no point in merging this in any form without adding application support at the same time,
and it will take me quite a bit of time to get to that personally.
To control bit depth and colorspace of video stream, we presently have the following tools in
master:x-nv-video[0].encoderCscMode >> 1COLORSPACE_REC_601COLORSPACE_REC_709COLORSPACE_REC_2020x-nv-video[0].encoderCscMode & 1COLOR_RANGE_LIMITEDCOLOR_RANGE_FULLx-nv-video[0].dynamicRangeMode01/launch?hdrMode=01Although 3 and 4 seem to be always used together by moonlight-qt.
I want to address two issues: