Apply lazy_required when inheriting from existing attributes#1
Open
skington wants to merge 16 commits intomoose:masterfrom
Open
Apply lazy_required when inheriting from existing attributes#1skington wants to merge 16 commits intomoose:masterfrom
skington wants to merge 16 commits intomoose:masterfrom
Conversation
initial bug report.
and the type you're using doesn't allow undef, you're in a world of hurt.
lazy_required at all. All a class needs to do is say use MooseX::LazyRequire; and the clone_and_inherit_options method of Moose::Meta::Attribute will be wrapped - for *all* attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug that was reported 8 years ago, and has been bugging me on-and-off for a while.
Basically, because _process_options isn't called if you're inheriting from another class, lazy_required wasn't getting applied in a sub-class. There was an initial test class supplied in the bug report that I've used as a base; I've updated some of the wording to (in my mind) make it clearer what we're trying to test.