Skip to content

give a better error if the value for Extends or Implements isn't valid#2260

Closed
seanmonstar wants to merge 1 commit intomootools:masterfrom
seanmonstar:master
Closed

give a better error if the value for Extends or Implements isn't valid#2260
seanmonstar wants to merge 1 commit intomootools:masterfrom
seanmonstar:master

Conversation

@seanmonstar
Copy link

No description provided.

@cpojer
Copy link
Member

cpojer commented Jan 26, 2012

I really don't see the value in this. Can we finally stop this madness?

@seanmonstar
Copy link
Author

No.

@ibolmo
Copy link
Member

ibolmo commented Jan 26, 2012

Moving this to 1.5, and if necessary we'll move this to 1.6. This is dependent on #2133 getting done.

@ibolmo
Copy link
Member

ibolmo commented Jan 26, 2012

This (partially) fixes #2257, btw.

@seanmonstar
Copy link
Author

Why is it dependent on has.js? This doesn't use has.

@ibolmo
Copy link
Member

ibolmo commented Jan 26, 2012

I've never been for failing silently in production, but 1.y.z has been released with that assumption. I think that without has.js we'd have to wait for 2.y.z to see MooTools throwing errors in live production.

@seanmonstar
Copy link
Author

I get that, but introducing this doesn't throw any more errors than it used to. The only difference is whether the error is understandable.

@cpojer
Copy link
Member

cpojer commented Jan 26, 2012

If this goes in for production use it must include an error routing mechanism otherwise it is useless.

@cpojer
Copy link
Member

cpojer commented Jan 26, 2012

as @timwienk noted in #mootools-dev, this breaks extending/implementing other (constructor) functions and therefore removes a useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants