Skip to content

Storing/retrieving the method/URL of the previous request.#2399

Closed
assertchris wants to merge 4 commits intomootools:masterfrom
assertchris:enhance-request-issue-2353
Closed

Storing/retrieving the method/URL of the previous request.#2399
assertchris wants to merge 4 commits intomootools:masterfrom
assertchris:enhance-request-issue-2353

Conversation

@assertchris
Copy link

@arian
Copy link
Member

arian commented Aug 13, 2012

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.method = method.toUpperCase();
this.url = url;

// ...

xhr.open(this.method, url, // ...

@ibolmo
Copy link
Member

ibolmo commented Aug 13, 2012

Sorry I just thought of a little UX problem:

var request = new Request({ url: '#' });
request.getURL(); // null <-- oops!

@assertchris
Copy link
Author

The docs clearly state that those methods return data from the last request, not from option state.

@arian
Copy link
Member

arian commented Aug 13, 2012

I think it should return what's passed in xhr.open.

@arian
Copy link
Member

arian commented Aug 13, 2012

but looking at the code that happens.. (except with GET data stuff)

@ibolmo ibolmo modified the milestones: 1.6, 1.5 Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants