use native getComputedStyle on IE9 and IE10#2419
Closed
gonchuki wants to merge 1 commit intomootools:masterfrom
Closed
use native getComputedStyle on IE9 and IE10#2419gonchuki wants to merge 1 commit intomootools:masterfrom
gonchuki wants to merge 1 commit intomootools:masterfrom
Conversation
Member
Author
There was a problem hiding this comment.
appending this here as the body might not exist yet at this point of the code execution (if js was included in head) and Opera returns empty values for window.getComputedStyle on a detached node.
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a robustness enhancement as discussed on #2414 (comment)
This relegates the use of non-standard
currentStyleto oldIE and Opera (which has a bug where sub-pixel values get rounded on nativegetComputedStyle, which can create jerky animations)As you see this also finally kills the usage of browser.* sniffs on
getStyle