Merged
Conversation
katzmo
reviewed
Sep 18, 2025
campaignion_csv.module
Outdated
| ], | ||
| 'IP Address' => [ | ||
| 'selector' => SubmissionPropertySelector::class, | ||
| 'property' => 'remote_addr', |
Contributor
There was a problem hiding this comment.
I'm pretty sure we do not collect IP addresses so this would only ever show "(unknown)".
IMHO tracking.user_id also shouldn’t be included, and the use of uid + user.name is limited to filtering out logged-in users. No idea what anyone would do with the number in serial?
Contributor
Author
There was a problem hiding this comment.
Good points. I brought it up with Urte and we decided to remove those fields.
Contributor
There was a problem hiding this comment.
Did you keep tracking.user_id on purpose? 🤔
Contributor
Author
There was a problem hiding this comment.
No, I somehow overlooked that uid and tracking.user_id are different things.... I've removed it now as well.
katzmo
approved these changes
Oct 8, 2025
katzmo
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.