[feat]: tag coloring #357
Open
[feat]: tag coloring #357
+59
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uiw6unoh is attempting to deploy a commit to the morethanmin's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
morethanmin
requested changes
Jun 7, 2024
Owner
morethanmin
left a comment
morethanmin
left a comment
There was a problem hiding this comment.
우선 PR 남겨주셔서 정말 감사드립니다! 리뷰가 늦어졌네요.
기존 카테고리 색상의 경우 같은 문자열에 대해 같은 색상이 적용되었는데, 해당 로직은 순서에 따라 색상이 적용되고 있네요.
같은 태그이더라도 순서에 따라 다른 색상이 적용된다면 다른 태그라고 인식할 수 있을 것 같습니다.
따라서 카테고리에 적용된 로직이 동일하게 적용되도록 수정되면 좋을 것 같습니다.
Author
|
태그 문자열에 기반한 해시 함수를 추가하였습니다!😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered an attractive feature discussed in issue #81 which had not yet been implemented.
I have adapted this feature to fit the latest codebase.
Related tickets
#81
PR Checklist