#158 but for MacOS: pass library existence check when dynamic library exists #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namic library exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#159 added support for using shared-library-only builds of rdkafka, but only for linux. This repeats that for MacOS. This turned out to be necessary while switching rdkafka to CMake on nixpkgs here.
Side note: i contemplated also adding windows library names, but I have no idea what the naming scheme there is, and I think these checks should better be done with some common mechanism like
find_libraryorpkg_check_modules(no idea which is proper). I btw also have never touched a MacOS, and I don't know whether this is sane, all I know is that it works on nixpkgs CI.