-
Notifications
You must be signed in to change notification settings - Fork 2
Добавить в WS3 функции прописи чисел и дат на казахском 2 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Erasiloco
wants to merge
10
commits into
master
Choose a base branch
from
fix/qazaq-spelling-598
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8444e3d
string to DateTime
Erasiloco bdb608a
GetDate
Erasiloco 413f500
added exception and try catch blocks
Erasiloco c09b618
Get Date try catch
Erasiloco 4895936
added constructor with ErrorCode into BadRequestException
Erasiloco df262ba
Add XML comment for GetOrdinal
bzaar fc501ad
Сервис умеет строить пропись для всех значений типа long.
Erasiloco 9b63c18
Error-Code
Erasiloco f559d45
comments
Erasiloco 2cf8497
parse response content
Erasiloco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,13 @@ namespace Morpher.WebService.V3 | |
| class BadRequestException : Exception | ||
| { | ||
| public int Status { get; } | ||
| public int ErrorCode { get; } | ||
|
|
||
| public BadRequestException(int status, int errorCode) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Конструктор не используется, следовательно, свойство ErrorCode всегда будет 0. |
||
| { | ||
| Status = status; | ||
| ErrorCode = errorCode; | ||
| } | ||
|
|
||
| public BadRequestException(int status) | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Morpher.WebService.V3.Client/Qazaq/QazaqWrongDateException.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace Morpher.WebService.V3.Qazaq | ||
| { | ||
| public class QazaqWrongDateException : InvalidArgumentException | ||
| { | ||
| public override string Message => | ||
| "Неправильная дата. Ожидается формат ГГГГ-ММ-ДД."; | ||
|
|
||
| public QazaqWrongDateException(string parameterName) | ||
| : base(parameterName) | ||
| { | ||
| } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
Morpher.WebService.V3.Client/Qazaq/QazaqWrongDayOfMonthException.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace Morpher.WebService.V3.Qazaq | ||
| { | ||
| public class QazaqWrongMonthException : InvalidArgumentException | ||
| { | ||
| public override string Message => | ||
| "Недопустимое значение числового параметра month. Допустимы значения от 1 до 12 включительно."; | ||
|
|
||
| public QazaqWrongMonthException(string parameterName) | ||
| : base(parameterName) | ||
| { | ||
| } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
Morpher.WebService.V3.Client/Qazaq/QazaqWrongMonthException.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace Morpher.WebService.V3.Qazaq | ||
| { | ||
| public class QazaqWrongDayOfMonthException : InvalidArgumentException | ||
| { | ||
| public override string Message => | ||
| "Недопустимое значение числового параметра day. Допустимы значения от 1 до 31 включительно."; | ||
|
|
||
| public QazaqWrongDayOfMonthException(string parameterName) | ||
| : base(parameterName) | ||
| { | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Все хорошо, только нужно где-то установить значение ErrorCode. Думаю, лучше это сделать в конструкторе BadRequestException.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ок