Skip to content

release: 0.1.0#4

Merged
Adityav369 merged 21 commits intomainfrom
release-please--branches--main--changes--next--components--morphik
Nov 5, 2025
Merged

release: 0.1.0#4
Adityav369 merged 21 commits intomainfrom
release-please--branches--main--changes--next--components--morphik

Conversation

@stainless-app
Copy link
Contributor

@stainless-app stainless-app bot commented Jul 17, 2025

Automated Release PR

0.1.0 (2025-11-05)

Full Changelog: v0.0.1...v0.1.0

Features

Bug Fixes

  • coerce nullable values to undefined (860b23e)

Chores

  • add package to package.json (76c89eb)
  • ci build action (9981ea1)
  • client: qualify global Blob (87a5454)
  • deps: update dependency @types/node to v20.17.58 (d4b8120)
  • internal: codegen related update (b0eec49)
  • internal: formatting change (25763d0)
  • internal: move publish config (f074720)
  • internal: remove redundant imports config (250ca52)
  • internal: update comment in script (e681df9)
  • internal: update global Error reference (2b9bc7b)
  • sync repo (2173455)
  • update @stainless-api/prism-cli to v5.15.0 (c23ccc3)
  • update CI script (142032e)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 17, 2025

Bug Report

Name Severity Example test case Description
check-release-environment script does not perform any checks High Run the script and observe that it always prints 'The environment is ready to push releases!' even if the environment is not properly configured. The check-release-environment script is intended to verify that the release environment is correctly set up before a release is performed. However, the script currently does not implement any checks and always reports a successful environment. This could lead to releases being performed in incorrect environments, potentially causing errors or security vulnerabilities.

Comments? Email us.

@stainless-app
Copy link
Contributor Author

stainless-app bot commented Jul 17, 2025

🧪 Testing

    To try out this version of the SDK, run:
    ```
    npm install 'https://pkg.stainless.com/s/morphik-typescript/998659148493c8c7a74b510288e511d408a8c585/dist.tar.gz'
    ```

    _Expires: Fri, 05 Dec 2025 22:51:52 GMT_

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 3a9f1d7 to 250ca52 Compare July 30, 2025 04:08
@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 30, 2025

Bug Report

Name Severity Example test case Description
Ineffective Release Environment Check High Run bin/check-release-environment. It will always report success, even if required environment variables are missing or other release prerequisites are not met. The check-release-environment script is intended to validate the release environment before a release. However, it lacks any actual checks and always returns success, rendering it ineffective.

Comments? Email us.

@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 30, 2025

Bug Report

Name: Inadequate Release Environment Checks
Severity: Critical
Example test case: Introduce a missing dependency or incorrect environment variable, then run the release doctor workflow. The workflow will pass.
Description: The check-release-environment script does not perform any checks, causing the release doctor workflow to always pass, even if the environment is not ready for a release.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 6225cb3 to f074720 Compare August 7, 2025 03:00
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 7, 2025

Bug Report

Name Severity Example test case Description
Missing bash in environment Critical Run the build script The build script fails because the bash interpreter is not found in the environment. This prevents the project from being built.
Ineffective release environment check High Create a pull request The check-release-environment script does not perform any checks and always passes, rendering it useless for validating the release environment.

Comments? Email us.

@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 7, 2025

Bug Report

Name Severity Example test case Description
bin/check-release-environment script does not perform any actual checks Critical Run the script. It will always report success, even if the environment is missing dependencies or has incorrect configurations. The bin/check-release-environment script initializes an empty errors array and never populates it with any checks. This results in the script always reporting a success, regardless of the actual state of the release environment.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 2101c9f to ea0eff8 Compare August 16, 2025 02:59
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 16, 2025

Bug Report

Name Severity Example test case Description
Incomplete Release Environment Checks Critical Run the release doctor workflow The bin/check-release-environment script doesn't perform any checks, causing the Release Doctor workflow to always pass, even with release environment issues.
Skipped API Tests High Run any test in tests/api-resources Most API tests are skipped because "Prism tests are disabled," indicating a problem with the mock server setup.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from ea0eff8 to 1237247 Compare August 16, 2025 03:03
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 16, 2025

Bug Report

Name Severity Example test case Description
Inadequate Release Environment Checks High Run the release doctor workflow without the necessary environment variables (e.g., NPM_TOKEN). The workflow will incorrectly report success. The check-release-environment script in bin/check-release-environment does not perform any meaningful checks on the release environment. It always returns a success message, even if required environment variables are missing or other necessary conditions are not met. This could lead to releases being published from incorrect or incomplete environments.
Unreliable Prism Mock Server Startup and Error Handling High Run the test suite with Prism failing to start due to an invalid OpenAPI spec. The tests will be skipped instead of failing. The scripts/mock script uses an unreliable method to determine if the Prism mock server has started successfully in daemon mode. It relies on parsing the .prism.log file for specific messages, which can change in future versions of Prism. Additionally, the error handling in scripts/test is insufficient to detect Prism startup failures, leading to tests being skipped instead of failing.
Redundant Publish Configuration Low N/A The repository has redundant publish configurations. The publishConfig in package.json ensures that the package is published with public access. However, the bin/publish-npm script is still used for publishing, which duplicates the configuration and could lead to inconsistencies if the two configurations diverge in the future. The bin/publish-npm script should be removed, and publishing should rely solely on Yarn's built-in publish mechanism and the publishConfig in package.json.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 1237247 to bad6f32 Compare August 20, 2025 04:51
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 20, 2025

Bug Report

Name Severity Example test case Description
No-op check-release-environment script High Run ./bin/check-release-environment The script always returns success, even if the release environment is misconfigured. It performs no checks. This creates a false sense of security.
Commented out tests Medium Run any test in the /tests/api-resources/ directory. All tests in this directory are skipped with the comment "Prism tests are disabled". This means the API client is not being adequately tested, and regressions could be introduced without being detected.
Missing Code Execution Tool Low Check the dependencies or codebase for the tool. The changelog indicates a code execution tool was added, but there is no explicit evidence of this tool being present in the codebase. Either the changelog is incorrect, the code execution tool was not correctly implemented, or the implementation is obscured.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from bad6f32 to ed3335b Compare August 22, 2025 04:26
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 22, 2025

Bug Report

Name Severity Example test case Description
Bash not available Critical Running yarn test The test suite cannot be run because the bash interpreter is not available in the environment. The test scripts rely on bash.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from ed3335b to a339663 Compare August 22, 2025 04:38
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 22, 2025

Bug Report

Name Severity Example test case Description
Incorrect release-please config Medium Check the contents of release-please-config.json. The file configures release-please for prerelease versioning, but the current version is 0.1.0 which is not a prerelease version. The versioning and prerelease fields in release-please-config.json are set for prerelease, while the current version is 0.1.0 (stable). This mismatch could cause problems with future releases. It should be either stable or prerelease.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from a339663 to 4a49593 Compare August 23, 2025 03:44
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 23, 2025

Bug Report

Name Severity Example test case Description
Broken Release Doctor Script Critical Run /root/morphik-ts/bin/check-release-environment The check-release-environment script uses bash-specific syntax, but bash is not available, causing the script to fail.
Prism Tests Disabled Medium Examine test files. Prism tests are disabled using test.skip. This hides potential API contract violations and should be addressed. A tracking issue should exist to re-enable them.
Misleading Commit Message Low Read commit message for patch 12. The commit message for patch 12 implies a code execution tool was added, but the change is actually a dependency update. This can cause confusion.
Incorrect Blob Qualification Low Use a Blob polyfill with a different prototype. The Blob qualification check might pass with an incorrect Blob polyfill, leading to unexpected behavior due to instanceof checks.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 4a49593 to 5751f23 Compare August 29, 2025 02:50
@jazzberry-ai
Copy link

jazzberry-ai bot commented Aug 29, 2025

Bug Report

Name Severity Example test case Description
Ineffective release environment check Critical The bin/check-release-environment script always reports success, even if required environment variables are missing. The bin/check-release-environment script initializes an empty array called errors, checks if the array has any elements, and if so, prints the errors. However, the array never has any elements added to it, so the script always succeeds.
BUILD_PATH path traversal vulnerability Medium If the BUILD_PATH variable is controllable by an attacker, they could specify a path that includes sensitive files. The scripts/utils/upload-artifact.sh script uses the BUILD_PATH environment variable to determine the directory to tar. If the BUILD_PATH variable is controllable by an attacker, they could potentially specify a path that includes sensitive files.
Incorrect HTTP method for requests with readable bodies High When options.body is a readable stream, the fetchOptions are being overridden with method: 'GET' When options.body is a readable stream, the fetchOptions are being overridden with method: 'GET', preventing users from calling any API endpoint with a readable body using HTTP methods other than GET, breaking core functionality.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 5751f23 to 611f2cf Compare September 6, 2025 03:09
@jazzberry-ai
Copy link

jazzberry-ai bot commented Sep 6, 2025

Bug Report

Name Severity Example test case Description
Incomplete release environment checks Critical Run bin/check-release-environment with missing environment variables The bin/check-release-environment script doesn't perform any actual checks on the release environment. It always reports success, even if required environment variables are missing, potentially leading to broken releases.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 611f2cf to 919375a Compare September 9, 2025 02:46
@jazzberry-ai
Copy link

jazzberry-ai bot commented Sep 9, 2025

Bug Report

Name Severity Example test case Description
Ineffective Release Doctor Critical Run the Release Doctor workflow. The check-release-environment script is empty and always returns success, rendering the Release Doctor workflow useless.
Prism Tests Disabled High Run the test suite. All Prism tests are currently disabled, leaving significant portions of the API client untested.
Potential Null/Undefined Bug Medium Use maybeCoerceInteger, maybeCoerceFloat, or maybeCoerceBoolean with null values. The change from === undefined to == null in coercion functions might cause unintended behavior in code that explicitly checked for undefined.

Comments? Email us.

@stainless-app
Copy link
Contributor Author

stainless-app bot commented Sep 15, 2025

Note: this release PR has been open for more than 60 days. Until this PR is merged, we will temporarily stop pushing codegen updates due to changes to Stainless' codegen.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from 919375a to f369fe3 Compare November 5, 2025 22:10
@jazzberry-ai
Copy link

jazzberry-ai bot commented Nov 5, 2025

Bug Report

Name Severity Example test case Description
Incorrect artifact upload Critical Run a CI build The upload-artifact.sh script now packages the dist directory into a .tgz file using npm pack, and then attempts to upload that .tgz file as a gzipped tarball. The server expects a gzipped tarball created by tar -cz, but it's now receiving an already compressed .tgz which will lead to upload failures and broken builds. The content type is also incorrect.

Comments? Email us.

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next--components--morphik branch from f369fe3 to 21baf71 Compare November 5, 2025 22:51
@jazzberry-ai
Copy link

jazzberry-ai bot commented Nov 5, 2025

Bug Report

Inconsistent use of null and undefined for optional parameters.
Severity: Low
Example test case: The IngestIngestTextParams interface has metadata defined as metadata?: unknown; and filename?: string | null;. This means that in the first case, the absence of metadata will result in undefined, and in the second case, in null.
Description: The backend might handle null and undefined differently, leading to errors or incorrect logic execution. It's best to have a consistent approach to optional parameters (either always use null or always use undefined). This issue applies to a variety of other params across the codebase.

Comments? Email us.

@Adityav369 Adityav369 merged commit 9942425 into main Nov 5, 2025
6 checks passed
@stainless-app
Copy link
Contributor Author

stainless-app bot commented Nov 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant