This repository was archived by the owner on Feb 11, 2020. It is now read-only.
fix: options missing when called storage backend#630
Open
eljefedelrodeodeljefe wants to merge 1 commit intomoscajs:masterfrom
eljefedelrodeodeljefe:fix-password
Open
fix: options missing when called storage backend#630eljefedelrodeodeljefe wants to merge 1 commit intomoscajs:masterfrom eljefedelrodeodeljefe:fix-password
eljefedelrodeodeljefe wants to merge 1 commit intomoscajs:masterfrom
eljefedelrodeodeljefe:fix-password
Conversation
Author
|
Currently fails due to missing backend object in some cases. Gonna be on vacation during the week. If you like to drive this forward I am gonna fix it Friday. |
Collaborator
|
I'm on vacation for the next two weeks myself. |
Author
|
Let's talk afterwards. Have a great time!
On Mon, 17 Apr 2017 at 02:06, Matteo Collina ***@***.***> wrote:
I'm on vacation for the next two weeks myself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#630 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADuBJEBotPnvqGIQdGAvWwlmia-tA6HTks5rwq0KgaJpZM4M-wUd>
.
--
*Robert Lindstädt*
Berlin, Germany
+49 176 701 904 78
|
Collaborator
|
CI is failing everywhere: https://travis-ci.org/mcollina/mosca/jobs/222653523#L1440. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when you call the example redis implementations, I believe the options won't get passed through. You can easily miss this locally, as redis for example is just calling its defaults. However, setting password is silent fail.
The expectation from the redis example is that all options from the ascoltatore object gets passed down.
Though this fix fixed the redis problem I would maybe rather recommend modernisation around inheritance and option passing. But I know you know what best to do. I offer my help, as I am currently doing a lot with MQTT in a my day job.
Example: