Identifier key as part of potential type#64
Conversation
|
Wait to merge until mosdef-hub/gmso#958 is ready to go. |
|
Probably need to hard and fast map the identifier to a tuple of values instead of the string. I.e. it should be |
…asses definitions
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
===========================================
- Coverage 93.29% 76.69% -16.61%
===========================================
Files 12 12
Lines 1641 1665 +24
===========================================
- Hits 1531 1277 -254
- Misses 110 388 +278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adding the string class "identifier" to potential objects, such as angletypes, bondtypes, etc, so these can be stored such that rewriting a forcefield using "classes" or "types" is possible.
Use Case
With PR, output is
Without PR, output is
**Note this requires a different version of gmso to run. Will need mosdef-hub/gmso#958