Allow to skip interactive tests & fix of test #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `menu(None)` is called, this exception happens:
File "/tmp/pystray-0.19.4/lib/pystray/_base.py", line 661, in cleaned
if not i.visible:
AttributeError: 'NoneType' object has no attribute 'visible'
Adding an `not i or` before that condition will make sure that `None`
will be considered as not visible.
The test itself fails as well:
File "/tmp/pystray-0.19.4/tests/menu_descriptor_tests.py", line 85, in test_menu_construct_from_none
self.assertEqual(
AssertionError: '' != '\n'
Instead just compare if `str(menu(None))` is the empty string.
Interactive tests cannot be executed in automated test environments. This adds a way to skip those tests via setting the `TEST_SKIP_INTERACTIVE` variable to `1`.
SuperSandro2000
approved these changes
May 24, 2024
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
I've cherry-picked Fix test_menu_construct_from_none test case into the nixpkgs package and it fixes the test for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to skip interactive test cases and fixes the
test_menu_construct_from_nonetest case.