Skip to content

Conversation

@darukutsu
Copy link
Contributor

@darukutsu darukutsu commented Apr 1, 2025

  • needs testing
  • needs update to work with multiselect branch
  • fix toggle gui quirks

fixes #29 kinda, user is not prompted but can install optdeps manually, with addition of #47 he could select optdeps he wants. Later we could add keybind which would auto-select all optdeps for example Shift+D.

I think code is more cleaner than in #47 since we not storing whole InfoRecord just some parts of it thus smaller size, saves memory. Although we need to add few things to make it work with #47. I will wait for more information on that. I will probably create another branch then and merge multiselect and this together in one pr.

I was thinking about 2 possible reworks:

Demonstration:
https://github.com/user-attachments/assets/c5b98d1d-722c-40e1-9498-54cc096c5ca7

@darukutsu
Copy link
Contributor Author

darukutsu commented Aug 19, 2025

#55 sparkled idea in my head and went to rework current concept and merge with it. It allowed me to shorten code around 30 lines of code (whole function... haven't done overal code cleaning so might be probably even more removal of unnecessary code). Plus another features as (ofc if we want not implemented yet but its easy):

  • show optional dependencies of optional dependencies
  • show make dependencies
  • collapse dependencies names

My question is @moson-mo is it better for you to review only code related to "list optional dependencies" here, so I'll cherry-pick only related changes OR i can close this PR and make updates in #55? Because cherry-picking needed changes will result in some duplicate code in both PRs.

This is how it looks for now:
Screenshot_20250819_205659_1920x1080

@darukutsu
Copy link
Contributor Author

Did some quickfixes and code cleaning between #55 and #49.

So before we've got #55+#49:

181-15+106-7 = 265

after git diff main..opt-deps-collapse-repetitive --numstat:

279-28 = 251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] List optional dependencies when installing packages

1 participant