Make connect and connect_robust generic#696
Open
glav-git wants to merge 2 commits intomosquito:masterfrom
Open
Make connect and connect_robust generic#696glav-git wants to merge 2 commits intomosquito:masterfrom
connect and connect_robust generic#696glav-git wants to merge 2 commits intomosquito:masterfrom
Conversation
mosquito
reviewed
Feb 21, 2026
Author
|
I noticed my commit introduced 2 new mypy errors: Unfortunately it's known issue: python/mypy#3737 and so far I was not able to find any solution that would satisfy both So i guess solution here is either |
Owner
|
@glav-git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #695
Just a draft on how issue could be resolved. Gave a detailed explanation on why this is a good idea in the issue itself. Since it's just a typing change, should't be a breaking change in the api?