Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an HTTP Expect: 100-continue handler to the ASGI app and refactors the internal apps stack management in ASGIMatchInfo.
- Introduces a new POST
/uploadendpoint that returns the parsedExpectheader and body size. - Adds a basic integration test for the
Expecthandler. - Refactors
ASGIMatchInfoto use aContextVarfor the current app and defines aResourceInfoDictTypedDict.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_fastapi_integration.py | Added imports, /upload endpoint, and test_expect_handler_basic |
| aiohttp_asgi/resource.py | Refactored ASGIMatchInfo to use ContextVar; added ResourceInfoDict |
Comments suppressed due to low confidence (1)
tests/test_fastapi_integration.py:179
- The response includes
received_expectbut the test does not assert its value. Add an assertion likeassert data["received_expect"] == "100-continue"to ensure the header is handled correctly.
assert data["body_size"] == len(test_data)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@meyerj what do you think if the current app is
ContextVarnow?