Open
Conversation
Squareys
force-pushed
the
webxr-example
branch
2 times, most recently
from
e9711bc to
8abcf07
Compare
Squareys
commented
Dec 10, 2019
Contributor
Author
|
@mosra This is ready for review! :) |
Squareys
force-pushed
the
webxr-example
branch
from
8abcf07 to
5520da1
Compare
mosra
reviewed
Dec 11, 2019
Owner
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
Looks great! A bunch of semi-minor things.
Squareys
force-pushed
the
webxr-example
branch
from
5520da1 to
aa5d428
Compare
emscripten-webxr is at e101ce7cfc3c92962a65771f43c2d61775edd348 Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
webxr-example
branch
from
aa5d428 to
e16a908
Compare
Contributor
Author
|
@mosra Done! |
Owner
|
Merged as 818731d, thank you! I'll update the docs and everything tomorrow, too late to do that today. Keeping this open as a reminder until we solve the Closure Compiler issue I mentioned privately -- I'd like to upload the minified version, ideally ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mosra,
as promised, with open sourcing of https://github.com/vhiterabbit/emscripten-webxr, here's a Magnum example.
This week, the first two browsers with support for the stable specification of the WebXR Device API will be released, hence I see it as valuable for magnum to be probably the first C++ graphics framework out there to support it.
Best,
Jonathan
TODO