-
Notifications
You must be signed in to change notification settings - Fork 122
fix: intel build restored #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe workflow configuration for container builds was updated to add the "intel" platform to the build matrix, ensuring containers are now built for "intel" alongside the existing platforms: "cuda," "vulkan," "cpu," and "musa." Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/containers.yml (1)
18-18: Optional: alphabetically sort matrix entries
Reordering the platforms improves readability and consistency.-platform: [intel, cuda, vulkan, cpu, musa] +platform: [cpu, cuda, intel, musa, vulkan]
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/containers.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-tests
🔇 Additional comments (1)
.github/workflows/containers.yml (1)
18-18: ```shell
#!/bin/bashDisplay the full build-container.sh to inspect ARCH usage and build logic
sed -n '1,200p' docker/build-container.sh
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
excellent. Thank you. |
Intel build of llama.cpp has been fixed, and has been running well for the past few days.
ref: https://github.com/ggml-org/llama.cpp/actions/runs/15671747643
Summary by CodeRabbit