Skip to content

fix(mjpegclient): strip leading space from digest parameter keys#3265

Merged
MichaIng merged 1 commit intodevfrom
fix/mjpgclient-digest-auth
Feb 7, 2026
Merged

fix(mjpegclient): strip leading space from digest parameter keys#3265
MichaIng merged 1 commit intodevfrom
fix/mjpgclient-digest-auth

Conversation

@MichaIng
Copy link
Member

@MichaIng MichaIng commented Feb 7, 2026

After splitting parameters key-value pairs by comma, they have a leading space. It remains as part of the key in the resulting dictionary, breaking utils.build_digest_header().

This change strips spaces from each key-value pair before creating the dictionary.

Before:

dict: {'realm': 'Motion', ' qop': 'auth', ' algorithm': 'MD5', ' nonce': '7c1781f7ebe05a8eb69d3f333038702b000000000888', ' opaque': '025f5245013b0a6c'}

After:

dict: {'realm': 'Motion', 'qop': 'auth', 'algorithm': 'MD5', 'nonce': '23878120785322c2082803516d0d70d3000000004954', 'opaque': '00950ecd01493b25'}

After splitting parameters key-value pairs by comma, they have a leading space. It remains as part of the key in the resulting dictionary, breaking `utils.build_digest_header()`.

This change strips spaces from each key-value pair before creating the dictionary.

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng MichaIng added this to the v0.43.2 milestone Feb 7, 2026
@MichaIng MichaIng self-assigned this Feb 7, 2026
@MichaIng MichaIng linked an issue Feb 7, 2026 that may be closed by this pull request
@MichaIng MichaIng merged commit 1ff0bda into dev Feb 7, 2026
20 checks passed
@MichaIng MichaIng deleted the fix/mjpgclient-digest-auth branch February 7, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Stream fails with digest authentication

1 participant