drop 0 minute pre and post transit legs#332
Open
traines-source wants to merge 1 commit intomotis-project:masterfrom
Open
drop 0 minute pre and post transit legs#332traines-source wants to merge 1 commit intomotis-project:masterfrom
traines-source wants to merge 1 commit intomotis-project:masterfrom
Conversation
Member
|
👍 |
Member
|
just not sure if it's best to do this in nigiri for one specific algorithm? wouldn't it be better to have it for all algorithms in MOTIS? |
Contributor
Author
|
Possible, it just felt ugly since then all the legs have to be shifted again. And because it was already done at this code location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up for motis-project/motis#1311. The 0 minute legs were only filtered out in the UI...
Is there an actually relevant case in which one would like to keep a 0 minute leg when
fp_leg.from_ != fp_leg.to_?EDIT: Ok according to the tests there is – but I would just fix the tests and set proper durations != 0 there?