Skip to content

Fix "Send All" folder action#405

Merged
gschier merged 3 commits intomainfrom
omnara/diagram-twerp
Feb 25, 2026
Merged

Fix "Send All" folder action#405
gschier merged 3 commits intomainfrom
omnara/diagram-twerp

Conversation

@gschier
Copy link
Member

@gschier gschier commented Feb 25, 2026

Fixes a Send All regression where folder sends could appear stuck in "sending".

Root Cause

In plugin host handling for send_http_request_request, the initial response upsert used UpdateSource::Plugin, while later send updates used UpdateSource::Window. The older plugin-sourced model update could be replayed and overwrite the newer closed state.

Fix

Use UpdateSource::from_window_label(window.label()) for the initial upsert in crates-tauri/yaak-app/src/plugin_events.rs so all updates for that response are consistently window-scoped.

Validation

  • Single-file change in crates-tauri/yaak-app/src/plugin_events.rs
  • cargo check -p yaak-app could not fully complete in this environment due missing vendored resource (vendored/protoc/include).

Feedback reference: https://yaak.app/feedback/posts/send-all-isnt-working-anymore

@gschier gschier merged commit 020589f into main Feb 25, 2026
4 checks passed
@gschier gschier deleted the omnara/diagram-twerp branch February 25, 2026 14:55
@gschier gschier changed the title fix: keep Send All response updates window-scoped Fix "Send All" folder action Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant