Skip to content

Correct newest_on_top and add width property #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct newest_on_top and add width property #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bootstrap-notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
},
offset: 20,
spacing: 10,
width: '200px',
z_index: 1031,
delay: 5000,
timer: 1000,
Expand Down Expand Up @@ -241,7 +242,8 @@
margin: '0px auto',
position: this.settings.position ? this.settings.position : (this.settings.element === 'body' ? 'fixed' : 'absolute'),
transition: 'all .5s ease-in-out',
zIndex: this.settings.z_index
zIndex: this.settings.z_index,
width: this.settings.width
},
hasAnimation = false,
settings = this.settings;
Expand Down Expand Up @@ -271,7 +273,7 @@

$(this.settings.element).append(this.$ele);

if (this.settings.newest_on_top === true) {
if (this.settings.newest_on_top !== true) { //this was set as === true, if newest_on_top is true, notifications should overlap on top of each other, contradicting with line 252
offsetAmt = (parseInt(offsetAmt) + parseInt(this.settings.spacing)) + this.$ele.outerHeight();
this.reposition(offsetAmt);
}
Expand Down