-
Notifications
You must be signed in to change notification settings - Fork 698
Support Docker siblings in IKFast plugin script #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rhaschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look reasonable and the goal is highly valuable.
However, I'm not sure why the CI tests didn't run and I can't trigger them manually.
Anyway, I ported your changes to MoveIt1 and there, the CI test fails:
https://github.com/ubi-agni/moveit/actions/runs/16938495966/job/48000931886
Any ideas?
moveit_kinematics/ikfast_kinematics_plugin/scripts/auto_create_ikfast_moveit_plugin.sh
Outdated
Show resolved
Hide resolved
moveit_kinematics/ikfast_kinematics_plugin/scripts/auto_create_ikfast_moveit_plugin.sh
Outdated
Show resolved
Hide resolved
b91bb53 to
6226e12
Compare
|
Thanks for the investigation, I have applied your suggestions now and rebased in main. The CI tests are currently failing on my fork because of the same deprecation error a few other recent PRs have been getting (e.g. this run for #2994). Seems like #3562 is trying to address this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 181 181
Lines 22649 22649
Branches 3108 3108
=====================================
Misses 22649 22649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
… container through a sibling container
Description
Adds support for running the IKFast plugin creation script
auto_create_ikfast_moveit_plugin.shfrom within a Docker container.The script uses Docker containers itself, and was attempting to share files with the spawned containers using bind mounts. If you create your main container with a bind mount to the Docker socket (
/var/run/docker.sock) then you are able to create sibling containers from inside, and thus would expect the script to execute correctly. The problem is that bind mounts always refer to the host-machine's paths, so if you try to run the script from inside a Docker container the mounts do not resolve correctly.I solved this by switching to explicit
docker createanddocker startcommands, and useddocker cpto copy files in and out, sincedocker cpsupports being run from inside a container. This works in-place and does not require any changes to documentation or processes.Checklist