Skip to content

Conversation

@NoahR-ATC
Copy link

Description

Adds support for running the IKFast plugin creation script auto_create_ikfast_moveit_plugin.sh from within a Docker container.

The script uses Docker containers itself, and was attempting to share files with the spawned containers using bind mounts. If you create your main container with a bind mount to the Docker socket (/var/run/docker.sock) then you are able to create sibling containers from inside, and thus would expect the script to execute correctly. The problem is that bind mounts always refer to the host-machine's paths, so if you try to run the script from inside a Docker container the mounts do not resolve correctly.

I solved this by switching to explicit docker create and docker start commands, and used docker cp to copy files in and out, since docker cp supports being run from inside a container. This works in-place and does not require any changes to documentation or processes.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look reasonable and the goal is highly valuable.
However, I'm not sure why the CI tests didn't run and I can't trigger them manually.
Anyway, I ported your changes to MoveIt1 and there, the CI test fails:
https://github.com/ubi-agni/moveit/actions/runs/16938495966/job/48000931886
Any ideas?

@NoahR-ATC NoahR-ATC force-pushed the main branch 2 times, most recently from b91bb53 to 6226e12 Compare August 26, 2025 04:03
@NoahR-ATC
Copy link
Author

Thanks for the investigation, I have applied your suggestions now and rebased in main. The CI tests are currently failing on my fork because of the same deprecation error a few other recent PRs have been getting (e.g. this run for #2994). Seems like #3562 is trying to address this.

@NoahR-ATC NoahR-ATC marked this pull request as ready for review August 26, 2025 04:22
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3e526af) to head (6226e12).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3517   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        181     181           
  Lines      22649   22649           
  Branches    3108    3108           
=====================================
  Misses     22649   22649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants